-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entproto: support enum values with special characters #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this . Please handle the case of two enums that normalize to a identical string with an informative error?
cb328f6
to
18fd280
Compare
Thanks for your feedback, that's a good point. I assume you mean two values within a single enum right? I updated the PR accordingly and also added a test. I also factored out a I also have a question: We are not being consistent in error messages with strings vs. quoted strings and I assume we are stuck with this for backwards compatibility? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jamslinger !
@jamslinger CI is red, can you check ? |
18fd280
to
d53d12b
Compare
I did a |
Thanks for the contribution @jamslinger ! |
Thanks for the support @rotemtam :) |
This fixes: ent/ent#3498